forked from kata-containers/kata-containers
-
Notifications
You must be signed in to change notification settings - Fork 42
policy: improve args and env variables validation #308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Redent0r
commented
Feb 11, 2025
Redent0r
commented
Feb 11, 2025
Redent0r
commented
Feb 11, 2025
Redent0r
commented
Feb 11, 2025
Redent0r
commented
Feb 11, 2025
danmihai1
reviewed
Feb 11, 2025
manuelh-dev
reviewed
Feb 11, 2025
manuelh-dev
reviewed
Feb 11, 2025
manuelh-dev
reviewed
Feb 11, 2025
manuelh-dev
reviewed
Feb 11, 2025
manuelh-dev
reviewed
Feb 11, 2025
Redent0r
commented
Feb 11, 2025
Redent0r
commented
Feb 18, 2025
1ab8fa6 to
05b6c7b
Compare
Redent0r
commented
Feb 19, 2025
Redent0r
commented
Feb 19, 2025
Redent0r
commented
Feb 19, 2025
Redent0r
commented
Feb 19, 2025
Redent0r
commented
Feb 19, 2025
5ab2596 to
f6f8fa7
Compare
4 tasks
danmihai1
reviewed
Feb 27, 2025
f6f8fa7 to
3f98aca
Compare
manuelh-dev
reviewed
Feb 28, 2025
manuelh-dev
reviewed
Feb 28, 2025
manuelh-dev
reviewed
Feb 28, 2025
manuelh-dev
reviewed
Feb 28, 2025
manuelh-dev
reviewed
Feb 28, 2025
3f98aca to
a151089
Compare
danmihai1
approved these changes
Feb 28, 2025
PolicyCreateContainerRequest will be a wrapper to CreateContainerRequest and will allow the agent to transform the input such that is easier to validate in the policy. Signed-off-by: Saul Paredes <[email protected]>
- Add environment variable map to the engine on the agent - Add environment variable map to the policy on genpolicy - Validate this environemnt variable map on the rules - Restrain some environment variable values that we expect to look like a subdomain and use a regex to validate them Signed-off-by: Saul Paredes <[email protected]>
- Mark old arg validation methods as deprecated - Mark old arg policy data field as deprecated Signed-off-by: Saul Paredes <[email protected]>
Add a new rule that validates args by substituting env variables received from the input. This new rule ensures that the args received from the input are the same as the args received from the policy. Signed-off-by: Saul Paredes <[email protected]>
Update samples Signed-off-by: Saul Paredes <[email protected]>
a151089 to
35b666c
Compare
Author
|
Force pushed to rebase against latest msft-main |
manuelh-dev
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge Checklist
upstream/missinglabel (orupstream/not-needed) has been set on the PR.Summary
policy: improve args and env variables validation. See commits for details
Depends on:
Test Methodology
Passing all fork samples locally
test run: